Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inclusion of Enhanced Geothermal Systems (EGS) #490

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Inclusion of Enhanced Geothermal Systems (EGS) #490

wants to merge 7 commits into from

Conversation

aljubrmj
Copy link

@aljubrmj aljubrmj commented Dec 6, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

Changes included the option to allow for EGS build based on CONUS supply curves developed in https://www.nature.com/articles/s41598-024-68580-8. Scripts included data retrieval from zenodo repo and attaching EGS supply specs and profiles to the network, and adjustment of EGS decline over years in multihorizon configurations.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.

@ktehranchi ktehranchi self-requested a review December 6, 2024 23:16
@ktehranchi
Copy link
Collaborator

ktehranchi commented Dec 12, 2024 •
edited
Loading

List of bugs to resolve:

  • 'nan' values for df_spec bus_id leads to no EGS data being added to the network if running non-USA interconnections
  • Extra "EGS existing" generators added to the network in add_extra components
  • Lifetime is set to 70 years or np.inf. In add_electricity they are set to np.inf.... the generators added in add_extra_components have lifetime of 70 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktehranchi ktehranchi Awaiting requested review from ktehranchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljubrmj @ktehranchi